Skip to content

ci: Revert #4911, run benches on v10 again #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

ci: Revert #4911, run benches on v10 again #4912

merged 1 commit into from
Sep 2, 2025
+60 −60

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Sep 1, 2025

No description provided.

@rschristian rschristian changed the title ci: Revert #4911 ci: Revert #4911, run benches on v10 again Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-7.40ms - +0.50ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.07ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-2.05ms - +0.63ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +4% (-0.42ms - +0.63ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.86ms - +0.62ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -9% - +5% (-0.19ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.49ms - +0.22ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.24ms - +1.31ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +8% (-0.27ms - +0.54ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +3% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local1003.50ms - 1008.69ms-unsure 🔍
-1% - +0%
-7.40ms - +0.50ms
preact-main1006.57ms - 1012.53msunsure 🔍
-0% - +1%
-0.50ms - +7.40ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.20ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms
preact-main19.19ms - 19.21msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.51ms - 16.55ms-unsure 🔍
-0% - +0%
-0.07ms - +0.00ms
preact-main16.53ms - 16.59msunsure 🔍
-0% - +0%
-0.00ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.55ms - 1.55msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.42ms - 71.43ms-unsure 🔍
-3% - +1%
-2.05ms - +0.63ms
preact-main70.24ms - 72.03msunsure 🔍
-1% - +3%
-0.63ms - +2.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.33ms - 6.91ms-unsure 🔍
-4% - +8%
-0.27ms - +0.54ms
preact-main6.19ms - 6.77msunsure 🔍
-8% - +4%
-0.54ms - +0.27ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.99ms - 16.57ms-unsure 🔍
-3% - +4%
-0.42ms - +0.63ms
preact-main15.74ms - 16.62msunsure 🔍
-4% - +3%
-0.63ms - +0.42ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5126

  • Commit: 25b9861

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.06ms - 62.04ms-unsure 🔍
-1% - +1%
-0.86ms - +0.62ms
preact-main61.12ms - 62.22msunsure 🔍
-1% - +1%
-0.62ms - +0.86ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.02ms-unsure 🔍
-0% - +1%
-0.00ms - +0.02ms
preact-main2.99ms - 3.00msunsure 🔍
-1% - +0%
-0.02ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.40ms - 26.23ms-unsure 🔍
-2% - +2%
-0.64ms - +0.54ms
preact-main25.44ms - 26.28msunsure 🔍
-2% - +2%
-0.54ms - +0.64ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.96ms - 33.86ms-unsure 🔍
-2% - +1%
-0.72ms - +0.49ms
preact-main33.12ms - 33.93msunsure 🔍
-1% - +2%
-0.49ms - +0.72ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.82ms - 31.79ms-unsure 🔍
-3% - +1%
-0.95ms - +0.45ms
preact-main31.05ms - 32.05msunsure 🔍
-1% - +3%
-0.45ms - +0.95ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.43ms - 27.23ms-unsure 🔍
-1% - +3%
-0.39ms - +0.72ms
preact-main26.28ms - 27.05msunsure 🔍
-3% - +1%
-0.72ms - +0.39ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.69ms - 24.73ms-unsure 🔍
-2% - +4%
-0.54ms - +0.88ms
preact-main23.55ms - 24.53msunsure 🔍
-4% - +2%
-0.88ms - +0.54ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.93ms - 21.48ms-unsure 🔍
-2% - +2%
-0.45ms - +0.32ms
preact-main21.00ms - 21.54msunsure 🔍
-2% - +2%
-0.32ms - +0.45ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5126

  • Commit: 25b9861

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.93ms - 2.11ms-unsure 🔍
-9% - +5%
-0.19ms - +0.10ms
preact-main1.95ms - 2.18msunsure 🔍
-5% - +9%
-0.10ms - +0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.99ms - 1.02ms-unsure 🔍
-1% - +3%
-0.01ms - +0.03ms
preact-main0.98ms - 1.00msunsure 🔍
-3% - +1%
-0.03ms - +0.01ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.37ms - 33.65ms-unsure 🔍
-1% - +1%
-0.49ms - +0.22ms
preact-main33.32ms - 33.97msunsure 🔍
-1% - +1%
-0.22ms - +0.49ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.45ms - 32.20ms-unsure 🔍
-4% - +4%
-1.24ms - +1.31ms
preact-main30.37ms - 32.21msunsure 🔍
-4% - +4%
-1.31ms - +1.24ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.96ms - 2.97msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Size Change: 0 B

Total Size: 79.1 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.15 kB
compat/dist/compat.mjs 4.08 kB
compat/dist/compat.module.js 4.08 kB
compat/dist/compat.umd.js 4.22 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.78 kB
dist/preact.min.js 4.8 kB
dist/preact.min.module.js 4.8 kB
dist/preact.min.umd.js 4.83 kB
dist/preact.mjs 4.79 kB
dist/preact.module.js 4.79 kB
dist/preact.umd.js 4.83 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@rschristian rschristian force-pushed the ci/restart-v10-benches branch from 25b9861 to 8345654 Compare September 1, 2025 19:30
@rschristian rschristian marked this pull request as ready for review September 1, 2025 19:30
@rschristian
Copy link
Member Author

rschristian commented Sep 1, 2025

Should be all good now! I reverted the commit to trigger the benches but it ran successfully, as you can see from the comment above.

@rschristian rschristian merged commit b0cb7c5 into v10.x Sep 2, 2025
10 checks passed
@rschristian rschristian deleted the ci/restart-v10-benches branch September 2, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rschristian @JoviDeCroock